adding SDK guides for readme.io for readme-sync#215
Merged
juancarlostong merged 7 commits intomasterfrom May 27, 2020
Merged
Conversation
Contributor
Author
|
@juancarlostong sorry, I didn't dig into travis, but is it likely this is failing for the same spell checker reason? |
Contributor
|
yes thats right, ill fix it in your branch and bring your branch up to date with master so you wont have problems merging. remember to git pull your local branch |
juancarlostong
force-pushed
the
docs-frances
branch
from
525451a to
8ad472f
Compare
juancarlostong
approved these changes
May 27, 2020
Contributor
|
@fscelliott or @juancarlostong please update the PR summary and make sure to fill in that section. |
Contributor
mikeproeng37
left a comment
mikeproeng37
left a comment
There was a problem hiding this comment.
This is ok to merge after you address the comments below. I'd say as a follow-up right after, we should convert those readme codeblocks to use MD codeblocks with ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "why", or other context.
docs-as-code approach
Test plan
Issues
no formal jira corresponds; see #devx-readme-sync slack channel