Adds IOptimizely interface #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can one of the admins verify this patch? |
1 similar comment
Contributor
|
Can one of the admins verify this patch? |
Contributor
mikeproeng37
left a comment
mikeproeng37
left a comment
There was a problem hiding this comment.
Thanks for submitting. We'll take a look. In the meantime, could you please go through our CONTRIBUTING MD doc and sign the CLA?
Contributor
Author
|
Done! |
OptimizelySDK/IOptimizely.cs
Outdated
| /// <param name="userAttributes">The user's attributes</param> | ||
| /// <param name="variableType">Variable type</param> | ||
| /// <returns>string | null Feature variable value</returns> | ||
| string GetFeatureVariableValueForType(string featureKey, string variableKey, string userId, |
Contributor
There was a problem hiding this comment.
Please remove this method, it is being used internally. no interface needed.
OptimizelySDK/Optimizely.cs
Outdated
| /// Send an impression event if the user is bucketed into an experiment using the feature. | ||
| /// </summary> | ||
| /// <param name="experimentKey">The experiment key</param> | ||
| /// <param name="featureKey">The experiment key</param> |
Contributor
There was a problem hiding this comment.
Please change 'experiment' to 'feature' in description.
mikeproeng37
suggested changes
Aug 18, 2018
Contributor
mikeproeng37
left a comment
mikeproeng37
left a comment
There was a problem hiding this comment.
Please address the feedback left by @msohailhussain
mikeproeng37
approved these changes
Aug 21, 2018
Contributor
mikeproeng37
left a comment
mikeproeng37
left a comment
There was a problem hiding this comment.
lgtm, will merge once tests pass on our end
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92.
Extracted an interface for all public members.
Also fixed a couple of the xmldocs.