Skip to content

Conversation

@spencerwilson-optimizely
Copy link
Contributor

@spencerwilson-optimizely spencerwilson-optimizely commented Aug 20, 2018

Summary

The former is deprecated, and as a result when customers install the package they see

$ npm i @optimizely/optimizely-sdk
npm WARN deprecated sprintf@0.1.5: The sprintf package is deprecated in favor of sprintf-js.

This migration resolves that, so now it's a silent, warning-less install.

Bundlephobia: old, new. 3.0 to 3.2 kB minified.

Test plan

Exhaustiveness:

$ ag 'require.*sprintf('\''|")\)' lib/ ; echo $?
1

Also, CI.

@coveralls
Copy link

coveralls commented Aug 20, 2018

Coverage Status

Coverage remained the same at 97.11% when pulling 5d5adae on sw/upgrade-sprintf into a72229a on master.

@tylerbrandt
Copy link
Contributor

I doubt we are stubbing sprintf so if the tests pass should be fine.

@spencerwilson-optimizely spencerwilson-optimizely merged commit 7ab1195 into master Aug 21, 2018
@spencerwilson-optimizely spencerwilson-optimizely deleted the sw/upgrade-sprintf branch August 21, 2018 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants