Fix branch conflicts #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjc1283
added a commit
that referenced
this pull request
Apr 22, 2019
Summary: - Only assign current datafile if truthy (replace typeof datafile !== 'undefined' check with datafile check) - Change urlTemplate option to be a sprintf-style format string, like Java's withFormat - Change backoff delay to increase up to 512 seconds after 7 errors, and clean up the backoff implementation a little - Clean up url handling in HttpPollingConfigManager. It was saving more private variables than necessary for data that never changes after the constructor. Test plan: Updated unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@optimizely/fullstack-devs