Skip to content

Allow react-sdk to be passed in as clientEngine #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jordangarcia merged 1 commit into from
May 28, 2019
Merged

Allow react-sdk to be passed in as clientEngine #279

jordangarcia merged 1 commit into from
May 28, 2019

Conversation

@jordangarcia
Copy link
Contributor

@jordangarcia jordangarcia commented May 24, 2019

Summary

  • Prepare for ReactSDK 0.3.0 release which will happen after javascript-sdk 3.2.0 is released.

Test plan

  • Unit tests

Issues

  • OASIS-4762

@coveralls
Copy link

coveralls commented May 24, 2019

Coverage Status

Coverage increased (+0.004%) to 97.591% when pulling f8cfff5 on jordan/add-react-sdk-client-engine into 47bd9c3 on master.

mikeproeng37
mikeproeng37 approved these changes May 24, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jordangarcia jordangarcia merged commit eb70509 into master May 28, 2019
@mikeproeng37 mikeproeng37 deleted the jordan/add-react-sdk-client-engine branch June 4, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjc1283 mjc1283 Awaiting requested review from mjc1283

1 more reviewer

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jordangarcia @coveralls @mikeproeng37