refactor(core): Run Prettier on packages/optimizely-sdk#420
Merged
circAssimilate merged 1 commit intomasterfrom Mar 4, 2020
Merged
refactor(core): Run Prettier on packages/optimizely-sdk#420circAssimilate merged 1 commit intomasterfrom
circAssimilate merged 1 commit intomasterfrom
Conversation
circAssimilate
force-pushed
the
derek/run_prettier_on_optimizely_sdk
branch
from
6d296bf to
e5dd734
Compare
mjc1283
approved these changes
Mar 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prettier --write "**/*.js"inpackages/optimizely-sdkprettier --write "**/*.ts"inpackages/optimizely-sdkPer the convo in Slack, we thought it would be a good idea to run Prettier on the entire
optimizely-sdkdirectory. Going forward, prettier will automatically run if the users IDE has the editorConfig setup as such. For VS Code, I personally like to add the"editor.formatOnSave": true,to mysettings.json.Test plan