Skip to content

fix: Changed getFeatureVariableJson to getFeatureVariableJSON #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mikeproeng37 merged 2 commits into from
Jul 6, 2020
Merged

fix: Changed getFeatureVariableJson to getFeatureVariableJSON #516

mikeproeng37 merged 2 commits into from
Jul 6, 2020

Conversation

@zashraf1985
Copy link
Contributor

@zashraf1985 zashraf1985 commented Jul 1, 2020

Summary

  • fixed case for getFeatureVariableJSON api
  • Instead of adding another check for apiName to the generic _getFeatureVariableForType function, Moved invalid instance check and log message to their own functions.

Test plan

All unit tests FSC tests should pass

@zashraf1985 zashraf1985 requested a review from a team as a code owner July 1, 2020 20:37
@coveralls
Copy link

coveralls commented Jul 1, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.009%) to 96.709% when pulling 13211ee on zeeshan/fix-case-get-feature-variable-json into 29ae7be on master.

mikeproeng37
mikeproeng37 approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, you'll also need to fix the js-testapp

@fayyazarshad fayyazarshad mentioned this pull request Jul 3, 2020
Merged
@mikeproeng37 mikeproeng37 merged commit 8ca4242 into master Jul 6, 2020
@mikeproeng37 mikeproeng37 deleted the zeeshan/fix-case-get-feature-variable-json branch July 6, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@mjc1283 mjc1283 mjc1283 approved these changes

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@zashraf1985 zashraf1985

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zashraf1985 @coveralls @mjc1283 @mikeproeng37