fix(bucketer): Don't log invalid variation ID warning when bucketed into traffic allocation range with empty string entityId #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto a traffic allocation range with empty string entityId
mjc1283
added a commit
that referenced
this pull request
Aug 10, 2020
…nto a traffic allocation range with empty string entityId (#549) Summary: Fix an issue introduced in #515. When bucket returns empty string, we shouldn't log a warning about invalid variation ID. Empty string is a valid value for the entityId property of traffic allocation range objects. There is no invalid variation ID in this situation. Test plan: Manually tested with A/B tests and rollouts. Added new unit test. Issues: OASIS-6890
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix an issue introduced in #515. When
bucketreturns empty string, we shouldn't log a warning about invalid variation ID. Empty string is a valid value for theentityIdproperty of traffic allocation range objects. There is no invalid variation ID in this situation.Test plan
Manually tested with A/B tests and rollouts. Added new unit test.
Issues
OASIS-6890