npm already adds node_modules/.bin to PATH #58
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Again, same issue as optimizely#56, there is no need to point directly at the node_modules bin because npm purposefully prepends `$(npm bin)` to `PATH` when running scripts. (Which is in addition to the fact that `./node_modules/karma/bin/karma` is the wrong path. It's brittle and reliant on karma always keeping that file in the same location with the same name. Correct location for binaries is where npm symlinks them, as instructed by the `bin` property of package.json: `./node_modules/.bin/karma`. But again, all is unnecessary because npm has the feature specifically to avoid this.)
jasonkarns
changed the title
Contributor
|
Hi @jasonkarns we're reviewing that change and we're going to look into the travis test failures as well. Thanks! |
Contributor
|
@jasonkarns can you please pull our latest changes to master and re-push your fix? |
Contributor
Author
|
done. still failing for unrelated reasons |
Contributor
|
Closing this as it is no longer relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Again, same issue as #56, there is no need to point directly at the node_modules bin because npm purposefully prepends
$(npm bin)toPATHwhen running scripts.(Which is in addition to the fact that
./node_modules/karma/bin/karmais the wrong path in the first place. It's brittle and reliant on karma always keeping that file in the same location and with the same name. Correct location for binaries is where npm symlinks them, as instructed by thebinproperty of package.json:./node_modules/.bin/karma. But again, all this is unnecessary because npm has the feature specifically to avoid this.)