fix(project config manager): Don't log an error when not initialized with datafile #589
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a regression introduced during refactoring for datafile accessor - any time the
datafileproperty of the object passed tocreateInstanceis missing or falsy, the logger will output (for example):Passing in an
sdkKey, but nodatafile, is valid and supported when callingcreateInstance, but this message leads the user to believe otherwise. In this situation, nothing is actually wrong, but the message says "Cannot start optimizely".To fix, in
ProjectConfigManager__initialize, whenconfig.datafileis falsy, we do not call__handleNewDatafile, avoiding the code path that eventually would log the error message.Test plan