fix(TS type defs): Restore missing types #594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yavorona
approved these changes
Oct 7, 2020
|
Hi @mjc1283 - thanks for addressing so quickly! I logged this issue + note to optimizely's helpdesk. I believe every type defined in https://github.com/optimizely/javascript-sdk/blob/master/packages/optimizely-sdk/lib/shared_types.ts was individually exported from the v4 release - can you make that everything is exported in this fix:
|
|
thank you! |
Contributor
|
@avifoxi we exported all the interfaces that have been previously defined and exported in the |
mjc1283
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
UserProfileServiceand several other types were removed by mistake from lib/index.d.ts.Test plan
Manual testing
Issues
#593