Skip to content

fix: Allow logLevel to support string type to avoid compiler type error #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yavorona merged 3 commits into from
Nov 18, 2020
Merged

fix: Allow logLevel to support string type to avoid compiler type error #627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
087955c
Fix LogLevel type to avoid compiler type error
yavorona Nov 18, 2020
4b4c901
Add string type to Config logLevel
yavorona Nov 18, 2020
0099320
Update changelog
yavorona Nov 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/optimizely-sdk/CHANGELOG.MD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

- In `Optimizely` class, use `any` type when assigning the return value of `setTimeout`. This is to allow it to type check regardless of whether it uses the browser or Node version of `setTimeout` ([PR #623](https://github.com/optimizely/javascript-sdk/pull/623)), ([Issue #622](https://github.com/optimizely/javascript-sdk/issues/622))

- Allow to pass string type `logLevel` to `createInstance`. ([Issue #614](https://github.com/optimizely/javascript-sdk/issues/614))

### New Features

- Added `enabled` field to decision metadata structure to support upcoming application-controlled introduction of tracking for non-experiment Flag decisions ([#619](https://github.com/optimizely/javascript-sdk/pull/619))
Expand Down
3 changes: 2 additions & 1 deletion packages/optimizely-sdk/lib/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ declare module '@optimizely/optimizely-sdk' {
eventDispatcher?: EventDispatcher;
logger?: LogHandler;
logLevel?:
| string
| enums.LOG_LEVEL.DEBUG
| enums.LOG_LEVEL.ERROR
| enums.LOG_LEVEL.INFO
Expand Down Expand Up @@ -205,7 +206,7 @@ declare module '@optimizely/optimizely-sdk/lib/plugins/logger' {
import { LogHandler } from '@optimizely/js-sdk-logging';

export interface LoggerConfig {
logLevel?: enums.LOG_LEVEL;
logLevel?: enums.LOG_LEVEL | string;
logToConsole?: boolean;
prefix?: string;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/optimizely-sdk/lib/shared_types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ export interface SDKOptions {
// flag to validate if this instance is valid
isValidInstance: boolean;
// level of logging i.e debug, info, error, warning etc
logLevel?: LogLevel;
logLevel?: LogLevel | string;
// LogHandler object for logging
logger?: LogHandler;
// sdk key
Expand Down