Skip to content

feat: Clone OptimizelyUserContext before calling decide api #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yavorona merged 2 commits into from
Jan 14, 2021
Merged

feat: Clone OptimizelyUserContext before calling decide api #643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f54e0b
Clone OptimizelyUsercOntext before calling decide apis
yavorona Jan 13, 2021
7433b9e
Add description to decision params
yavorona Jan 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/optimizely-sdk/lib/optimizely_decision/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,17 @@ import OptimizelyUserContext from '../optimizely_user_context';

export interface OptimizelyDecision {
variationKey: string | null;
// The boolean value indicating if the flag is enabled or not
enabled: boolean;
// The collection of variables associated with the decision
variables: { [variableKey: string]: unknown };
// The rule key of the decision
ruleKey: string | null;
// The flag key for which the decision has been made for
flagKey: string;
// A copy of the user context for which the decision has been made for
userContext: OptimizelyUserContext;
// An array of error/info messages describing why the decision has been made.
reasons: string[];
}

Expand Down
14 changes: 11 additions & 3 deletions packages/optimizely-sdk/lib/optimizely_user_context/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export default class OptimizelyUserContext {
options: OptimizelyDecideOptions[] = []
): OptimizelyDecision {

return this.optimizely.decide(this, key, options);
return this.optimizely.decide(this.cloneUserContext(), key, options);
}

/**
Expand All @@ -85,7 +85,7 @@ export default class OptimizelyUserContext {
options: OptimizelyDecideOptions[] = [],
): { [key: string]: OptimizelyDecision } {

return this.optimizely.decideForKeys(this, keys, options);
return this.optimizely.decideForKeys(this.cloneUserContext(), keys, options);
}

/**
Expand All @@ -97,7 +97,7 @@ export default class OptimizelyUserContext {
options: OptimizelyDecideOptions[] = []
): { [key: string]: OptimizelyDecision } {

return this.optimizely.decideAll(this, options);
return this.optimizely.decideAll(this.cloneUserContext(), options);
}

/**
Expand All @@ -108,4 +108,12 @@ export default class OptimizelyUserContext {
trackEvent(eventName: string, eventTags?: EventTags): void {
this.optimizely.track(eventName, this.userId, this.attributes, eventTags);
}

private cloneUserContext(): OptimizelyUserContext {
return new OptimizelyUserContext({
optimizely: this.getOptimizely(),
userId: this.getUserId(),
attributes: this.getAttributes(),
})
}
}