Skip to content

fix: Support multiple experiments in flag #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yavorona merged 9 commits into from
May 13, 2021
Merged

fix: Support multiple experiments in flag #664

yavorona merged 9 commits into from
May 13, 2021

Conversation

@yavorona
Copy link
Contributor

@yavorona yavorona commented Apr 29, 2021 •
edited
Loading

Summary

  • _getVariationForFeatureExperiment method is updated to fix group and multiple experiment issues.

Test plan

Issues

@yavorona yavorona self-assigned this Apr 29, 2021
@yavorona yavorona requested a review from a team as a code owner April 29, 2021 03:01
jaeopt
jaeopt reviewed Apr 29, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@coveralls
Copy link

coveralls commented May 12, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 97.001% when pulling d17861d on pnguen/fix-multiple-experiments-scenarios into d9f8e24 on master.

@yavorona yavorona removed their assignment May 12, 2021
@yavorona yavorona requested a review from zashraf1985 May 12, 2021 17:12
jaeopt
jaeopt approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yavorona yavorona merged commit adf18af into master May 13, 2021
@yavorona yavorona deleted the pnguen/fix-multiple-experiments-scenarios branch May 13, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaeopt jaeopt jaeopt approved these changes

@zashraf1985 zashraf1985 Awaiting requested review from zashraf1985

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yavorona @coveralls @jaeopt @zashraf1985