fix: Send correct impression event data for projects with duplicate rule keys #690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yavorona
added a commit
that referenced
this pull request
Jul 15, 2021
…ule keys (#690) * Send correct impression event data + fix unit tests * Add getExperimentId unit tests * Add unit test for getVariationIdFromExperimentIdAndVariationKey + clean up * fix emitNotificationCenterActivate
yavorona
restored the
pnguen/fix-impression-event-for-dublicate-rule-keys
branch
yavorona
added a commit
that referenced
this pull request
Jul 15, 2021
…ule keys (#690) * Send correct impression event data + fix unit tests * Add getExperimentId unit tests * Add unit test for getVariationIdFromExperimentIdAndVariationKey + clean up * fix emitNotificationCenterActivate
raju-opti
deleted the
pnguen/fix-impression-event-for-dublicate-rule-keys
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provide correct variation id and experiment id when building and sending an impression event.
Test plan
local bundle + unit tests + fsc