-
Notifications
You must be signed in to change notification settings - Fork 85
feat: ODP Datafile Parsing #775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ODP Datafile Parsing #775
Conversation
jaeopt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! A couple of changes suggested.
zashraf1985
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Great! Suggested one change.
|
@jaeopt , @zashraf1985 - updated to resolve your comments above. Let me know if the solution looks good to you or if I missed anything... thanks! |
jaeopt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zashraf1985
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Great!
Summary
Technical Changes
integrationsfield to theproject_config_schemacomposed of array items which are objects with the keys ofkey,host, andpublicKey.IntegrationsProjectConfiginterface to prepare catching this new incomingintegrationsfield:integrationsintegrationKeyMap(Optional)publicKeyForOdp(Optional)hostForOdp(Optional)allSegmentsgetAudienceSegmentsfunction from project_config. This function is used for recursively evaluating through audience conditions qualified matches, returning a concatenated array of all condition values where the conditionmatchis equal to the valuequalified.Test plan
getAudienceSegmentsworks as a standalone function.Issues
Note: Prettier caused many whitespace changes to be applied. To see only the related changes, click the gear icon and select "Hide whitespace changes" in the diff.