feat: ODP REST API for Sending ODP Events #786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeopt
requested changes
Sep 21, 2022
Contributor
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
I see missing some error handlings. Also we can consider removing {GraphQLManager, RestApiManager} since most logic is in OdpClient. See my comments for more context.
packages/optimizely-sdk/lib/utils/http_request_handler/request_handler_factory.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Jae Kim <45045038+jaeopt@users.noreply.github.com>
Co-authored-by: Jae Kim <45045038+jaeopt@users.noreply.github.com>
This reverts commit f40bd80.
WIP REST API manager test
zashraf1985
suggested changes
Sep 22, 2022
Contributor
zashraf1985
left a comment
zashraf1985
left a comment
There was a problem hiding this comment.
Great Work Overall! Requested a few changes.
packages/optimizely-sdk/lib/utils/http_request_handler/browser_request_handler.ts
Show resolved
Hide resolved
packages/optimizely-sdk/lib/utils/http_request_handler/request_handler_factory.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Zeeshan Ashraf <35262377+zashraf1985@users.noreply.github.com>
…o mike/odp-rest-api-interface # Conflicts: # packages/optimizely-sdk/lib/plugins/odp/graphql_manager.ts
jaeopt
requested changes
Sep 23, 2022
Contributor
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
Looks good! A few more small changes suggested.
packages/optimizely-sdk/lib/utils/http_request_handler/request_handler_factory.ts
Outdated
Show resolved
Hide resolved
jaeopt
requested changes
Sep 26, 2022
Contributor
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
Changes look good. I found a couple of cases inconsistent.
# Conflicts: # packages/optimizely-sdk/lib/utils/enums/index.ts # packages/optimizely-sdk/lib/utils/http_request_handler/request_handler_factory.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding module to provide an internal service for sending events to ODP's REST API.
Test plan
Issues