refactor: Refactored Odp Code to get rid of platform specific checks #813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeopt
requested changes
Apr 7, 2023
Contributor
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
Looks great! I see some platform dependent logic for segmentManager as well. If we can have consistent structure for both segmentManager and eventManager, it may look better.
Contributor
|
@jaeopt - went ahead and resolved tests and finished splitting off odpmanager responsibilities into variant-specific implementations. |
jaeopt
approved these changes
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactored Odp Code to get rid of platform specific checks.
Test plan
Not tested at all. Relying on John to test and fix unit tests if needed
Issues
Merging into changes related to FSSDK-9023