Skip to content

Conversation

@raju-opti
Copy link
Contributor

@raju-opti raju-opti commented Jun 7, 2023

Summary

On odp config update:

  • All queued odp events should be flushed
  • Cache should be reset

These tests were previously failing because on datafile update, odp config was not being updated. That is fixed in this PR.

Test plan

  • All existing tests should pass

Issues

@coveralls
Copy link

Coverage Status

coverage: 90.515%. remained the same when pulling e3fae1d on raju/fix-fsc into 5765e28 on master.

@raju-opti raju-opti changed the title [FSSDK-9361] fix failing fsc test for sending all events on config update [FSSDK-9361] fix failing fsc tests for odp config update Jun 7, 2023
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raju-opti raju-opti merged commit 280f2a0 into master Jun 8, 2023
@raju-opti raju-opti deleted the raju/fix-fsc branch June 8, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants