Skip to content

Sending event when variation of an experiment has feature disabled #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aliabbasrizvi merged 4 commits into from
Jun 19, 2018
Merged

Sending event when variation of an experiment has feature disabled #128

aliabbasrizvi merged 4 commits into from
Jun 19, 2018

Conversation

@aliabbasrizvi
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi commented Jun 19, 2018

No description provided.

@aliabbasrizvi aliabbasrizvi requested a review from a team June 19, 2018 17:00
@tylerbrandt
Copy link

tylerbrandt commented Jun 19, 2018

build

3 similar comments
@tylerbrandt
Copy link

tylerbrandt commented Jun 19, 2018

build

@tylerbrandt
Copy link

tylerbrandt commented Jun 19, 2018

build

@tylerbrandt
Copy link

tylerbrandt commented Jun 19, 2018

build

@coveralls
Copy link

coveralls commented Jun 19, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 99.649% when pulling 3edd029 on ali/fix_event_dispatch_no_ff into 29515fa on master.

mikeproeng37
mikeproeng37 approved these changes Jun 19, 2018
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aliabbasrizvi aliabbasrizvi merged commit 2b95621 into master Jun 19, 2018
@aliabbasrizvi aliabbasrizvi deleted the ali/fix_event_dispatch_no_ff branch June 19, 2018 17:50
aliabbasrizvi added a commit that referenced this pull request Jun 19, 2018
@aliabbasrizvi
Sending event when variation of an experiment has feature disabled (#128
25dbca5 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aliabbasrizvi @tylerbrandt @coveralls @mikeproeng37