feat(datafile-management): Integrate config_manager with Optimizely #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Not ready for review yet. |
aliabbasrizvi
changed the title
mikeproeng37
suggested changes
Jun 11, 2019
| self.logger.exception(error_msg) | ||
| self.error_handler.handle_error(error_to_handle) | ||
| return | ||
| if not self.config_manager: |
Contributor
There was a problem hiding this comment.
Does it make sense to combine this with the sdk_key check? There doesn't seem to be additional logic outside of the inner if clause
mjc1283
reviewed
Jun 11, 2019
aliabbasrizvi
force-pushed
the
datafile-manager
branch
from
90b88fc to
e078a48
Compare
aliabbasrizvi
force-pushed
the
ali/integrate_with_optly
branch
from
fbea190 to
1e56ddd
Compare
mjc1283
approved these changes
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this change, we move to using
config_manager.PollingConfigManagerandconfig_manager.StaticConfigManagerbased on how the SDK is initialized. With the change the SDK may be initialized by either:sdk_keyonly: in this case, thePollingConfigManagerwill be used which will request and update config at default interval of 5 minutes.datafileonly: in this case, theStaticConfigManagerwill be used and the SDK will continue to behave like it has done previously i.e. it will need to be re-initialized.PollingConfigManagerwill be used and the SDK will start with a config based on the provided datafile and will update config at default interval of 5 minutes.To use more options on the
PollingConfigManagerlike differentupdate_interval,url,url_template, users will have the option to create an instance ofPollingConfigManagerand pass it toOptimizelyasconfig_manageroption.Test plan