Skip to content

Conversation

@aliabbasrizvi
Copy link
Contributor

Summary

Logger in config_manager was being initialized incorrectly. Fixing that.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 98.756% when pulling 6aea698 on ali/fix_logging_issue into b37f0d4 on datafile-manager.

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, silly mistake. Ship it!

@aliabbasrizvi aliabbasrizvi merged commit 251b65f into datafile-manager Jun 18, 2019
@aliabbasrizvi aliabbasrizvi deleted the ali/fix_logging_issue branch June 18, 2019 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants