Skip to content

Making notification_center optional for optimizely.Optimizely. #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aliabbasrizvi merged 1 commit into from
Jul 3, 2019
Merged

Making notification_center optional for optimizely.Optimizely. #186

aliabbasrizvi merged 1 commit into from
Jul 3, 2019

Conversation

@aliabbasrizvi
Copy link
Contributor

@aliabbasrizvi aliabbasrizvi commented Jul 3, 2019

Summary

This change introduces notification_center on optimizely.Optimizely thereby allowing instance of it to be shared by Optimizely and all classes under config_manager. Previously, config_manager had its own NotificationCenter instance and optimizely.Optimizely had its own instance leading to issues.

@aliabbasrizvi aliabbasrizvi requested review from a team, Mat001 and mikeproeng37 July 3, 2019 01:55
@coveralls
Copy link

coveralls commented Jul 3, 2019

Coverage Status

Coverage decreased (-0.2%) to 98.525% when pulling 58f65a2 on ali/fix_notif_center into dd0ff90 on datafile-manager.

Mat001
Mat001 approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mikeproeng37
mikeproeng37 approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aliabbasrizvi aliabbasrizvi merged commit e7c3076 into datafile-manager Jul 3, 2019
@aliabbasrizvi aliabbasrizvi deleted the ali/fix_notif_center branch September 12, 2019 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mat001 Mat001 Mat001 approved these changes

+1 more reviewer

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aliabbasrizvi @coveralls @mikeproeng37 @Mat001