Skip to content

Conversation

@aliabbasrizvi
Copy link
Contributor

Updating feature evaluation logs so that they apply to both rollouts and experiments

Comment on lines -480 to -482
self.logger.info(
'Value for variable "%s" for variation "%s" is "%s".' % (variable.key, variation.key, variable_value)
)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These messages combined with the ones in optimizely.py were redundant.

@aliabbasrizvi aliabbasrizvi removed their assignment Jul 7, 2020
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aliabbasrizvi aliabbasrizvi force-pushed the ali/fix_log_messages branch from 39a9c31 to 9fffe99 Compare July 7, 2020 22:16
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 97.096% when pulling 9fffe99 on ali/fix_log_messages into c9fca91 on master.

@aliabbasrizvi aliabbasrizvi merged commit f9484bd into master Jul 7, 2020
@aliabbasrizvi aliabbasrizvi deleted the ali/fix_log_messages branch July 7, 2020 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants