Skip to content

feat: added enabled field to decision metadata #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pawels-optimizely merged 1 commit into from
Nov 13, 2020
Merged

feat: added enabled field to decision metadata #306

pawels-optimizely merged 1 commit into from
Nov 13, 2020

Conversation

@oakbani
Copy link
Contributor

@oakbani oakbani commented Nov 10, 2020

Summary

  • This adds 'enabled' field to decision metadata.
  • 'enabled' is set to feature_enabled value for is_feature_enabled and True for activate.

Test plan

  • Fixed existing unit tests.
  • Manually tested with FSC.

@oakbani oakbani requested a review from a team as a code owner November 10, 2020 13:38
@coveralls
Copy link

coveralls commented Nov 10, 2020

Coverage Status

Coverage increased (+0.003%) to 96.354% when pulling a81a892 on oakbani/metadata-enabled into edf5528 on master.

@pawels-optimizely pawels-optimizely merged commit 50a5daa into master Nov 13, 2020
@pawels-optimizely pawels-optimizely deleted the oakbani/metadata-enabled branch November 13, 2020 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pawels-optimizely pawels-optimizely pawels-optimizely approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oakbani @coveralls @pawels-optimizely