ci: fix cryptography wheel build for pypy and pypy3 #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mat001
approved these changes
Mar 1, 2021
Contributor
|
@oakbani LGTM. Keep in mind that I had to rerun pypy3 unit tests 5 times before they passed. A single tests was failing (polling manager) until it passed (flakey?). I noticed that same test failed occasionally in previous builds but not sure if it's 4/5 runs or less flakey. I doub't that cryptography version update causes that test to frequently fail... |
Contributor
Author
|
@Mat001 Yeah, this flaky test has been always there. It's not related to this cryptography fix. This flaky test occurs more on the pypy versions as compared to other python versions. We should address this test in a separate PR |
Contributor
Author
|
Closing in favor of #320 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Unit tests on Python pypy and pypy3 have been failing consistently for quite some time. On detailed investigation, cryptography package is required by the requests[security] module. Although the latest cryptography version does support pypy, it doesn't build for some reason.
Setting cryptography package to a static previous version revealed that Python 3.4 support has been dropped after cryptography 2.8. Therefore, in this PR we specify version bounds that support all of our supported python versions.
Test plan
All checks continue to pass.
Issues