Skip to content

[OASIS-7808] Upgrade pyrsistent to 0.16.0 to match monolith #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mat001 merged 1 commit into from
Jul 6, 2021
Merged

[OASIS-7808] Upgrade pyrsistent to 0.16.0 to match monolith #343

Mat001 merged 1 commit into from
Jul 6, 2021

Conversation

@Mat001
Copy link
Contributor

@Mat001 Mat001 commented Jul 6, 2021

Summary

  • Upgrading Py SDK for dogfooding in the monolith. Part of that is upgrading Pyrsistent lib because the version mismatch causes MOnolith to not start.
  • So Pyrsistent in Py SDK importer in monolith and Pyrsistent used in the monolith itself need to match.

Test plan

Issues

@Mat001 Mat001 requested a review from a team as a code owner July 6, 2021 16:58
@The-inside-man
Copy link
Contributor

The-inside-man commented Jul 6, 2021

LGTM

@coveralls
Copy link

coveralls commented Jul 6, 2021

Coverage Status

Coverage remained the same at 95.769% when pulling c29633f on mpirnovar/test_upgrading_pyrsistent into b55582c on master.

@Mat001 Mat001 merged commit 8c3cfc1 into master Jul 6, 2021
@Mat001 Mat001 deleted the mpirnovar/test_upgrading_pyrsistent branch July 6, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@The-inside-man The-inside-man The-inside-man approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Mat001 Mat001

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Mat001 @The-inside-man @coveralls