fix: odp issues identified by FSC #412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mat001
approved these changes
Jan 26, 2023
Contributor
Mat001
left a comment
Mat001
left a comment
There was a problem hiding this comment.
yup, we went through this. looks ok
jaeopt
approved these changes
Jan 26, 2023
Contributor
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
LGTM - a suggestion about adding a test.
| # error is logged in create_user_context | ||
| if user_context is None: | ||
| return None | ||
| user_context = OptimizelyUserContext(self, self.logger, user_id, attributes, False) |
Contributor
There was a problem hiding this comment.
We can add a unit test validating we do not fire ODP events with any legacy APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix some issues identified by FSC tests
Test plan
Ticket