Skip to content

[FSSDK-9100]: Updating old dependencies. #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yasirfolio3 merged 3 commits into from
Jun 28, 2023
Merged

[FSSDK-9100]: Updating old dependencies. #427

yasirfolio3 merged 3 commits into from
Jun 28, 2023

Conversation

@yasirfolio3
Copy link
Contributor

@yasirfolio3 yasirfolio3 commented Jun 27, 2023

Summary

  • Updating old dependencies

Test plan

  • All tests should pass

Issues

@yasirfolio3 yasirfolio3 added the wip Work in progress label Jun 27, 2023
@yasirfolio3 yasirfolio3 changed the title [FSSDK-9100]: Updating old dependencies. [FSSDK-9100]: Updating old dependencies. (DO NOT REVIEW) Jun 27, 2023
@yasirfolio3 yasirfolio3 reopened this Jun 27, 2023
@yasirfolio3 yasirfolio3 marked this pull request as ready for review June 28, 2023 18:42
@yasirfolio3 yasirfolio3 requested a review from a team as a code owner June 28, 2023 18:42
@yasirfolio3 yasirfolio3 changed the title [FSSDK-9100]: Updating old dependencies. (DO NOT REVIEW) [FSSDK-9100]: Updating old dependencies. Jun 28, 2023
@yasirfolio3 yasirfolio3 removed the wip Work in progress label Jun 28, 2023
andrewleap-optimizely
andrewleap-optimizely reviewed Jun 28, 2023
View reviewed changes
andrewleap-optimizely
andrewleap-optimizely approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@andrewleap-optimizely andrewleap-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yasirfolio3 yasirfolio3 merged commit c44f712 into master Jun 28, 2023
@yasirfolio3 yasirfolio3 deleted the yasir/FSSDK-9100 branch June 28, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@andrewleap-optimizely andrewleap-optimizely andrewleap-optimizely approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yasirfolio3 yasirfolio3

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yasirfolio3 @andrewleap-optimizely