-
Notifications
You must be signed in to change notification settings - Fork 27
feat: add odp segment manager #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
zashraf1985
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Great! Suggested a few changes.
jaeopt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A few small changes suggested.
Some ruby contexts I cannot cover :)
lib/optimizely/odp/odp_config.rb
Outdated
| @api_key = api_key | ||
| @api_host = api_host | ||
| @segments_to_check = segments_to_check | ||
| @odp_enabled = !api_key.nil? && !api_host.nil? ? true : false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll have a similar flag (odpEnabled) in the OdpManager level, which disable all ODP functions including segments and events. This may be conflict with that. We can clean it up here and visit again at the top level.
jaeopt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zashraf1985
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Great!
Summary
Adds OdpSegmentManager to provide internal services for fetching segments from the ODP server.
Test plan
Ticket
OASIS-8446