feat: add odp to project and user context #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaeopt
requested changes
Sep 29, 2022
Contributor
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
Looks great! We need to discuss a few open issues. See my comments.
Mat001
reviewed
Oct 1, 2022
Contributor
Mat001
left a comment
Mat001
left a comment
There was a problem hiding this comment.
@andrewleap-optimizely one comment
jaeopt
requested changes
Oct 4, 2022
Contributor
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
Looks good. A couple of customization support we need to discuss.
Mat001
reviewed
Oct 5, 2022
jaeopt
requested changes
Oct 7, 2022
Contributor
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
Looks great! A small change suggested and a couple of issues to discuss.
jaeopt
requested changes
Oct 7, 2022
Contributor
jaeopt
left a comment
jaeopt
left a comment
There was a problem hiding this comment.
This solution looks good! One more clean up suggested.
zashraf1985
suggested changes
Oct 11, 2022
Contributor
zashraf1985
left a comment
zashraf1985
left a comment
There was a problem hiding this comment.
Looks Great! I have a few questions that i have added as review comments
zashraf1985
approved these changes
Oct 13, 2022
Comment on lines
+136
to
+141
|
|
||
| if @event_manager.running? | ||
| @event_manager.update_config | ||
| elsif @odp_config.odp_state == ODP_CONFIG_STATE[:INTEGRATED] | ||
| @event_manager.start!(@odp_config) | ||
| end |
andrewleap-optimizely
deleted the
aleap/add_odp_to_client_and_user_context
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
OptimizelyUserContext
Optimizely::Project
Test plan
Fixed existing tests and added tests to:
Ticket