Skip to content

fix(ats): enhance or fix ODP integration #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jaeopt merged 5 commits into from
Dec 16, 2022
Merged

fix(ats): enhance or fix ODP integration #470

jaeopt merged 5 commits into from
Dec 16, 2022

Conversation

@jaeopt
Copy link
Contributor

@jaeopt jaeopt commented Oct 28, 2022

Summary

  • When a vuid is used as a userId (UserContext is created without userId), identifyUser event should not include redundant vuids in event identifiers.

Test plan

unit tests

Issues

  • FSSDK-8413

@jaeopt jaeopt requested a review from a team as a code owner October 28, 2022 23:00
@coveralls
Copy link

coveralls commented Oct 28, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 95.199% when pulling e83456f on jae/ats-2 into 86a328f on master.

@jaeopt jaeopt closed this Dec 5, 2022
@jaeopt jaeopt reopened this Dec 5, 2022
@jaeopt jaeopt closed this Dec 14, 2022
@jaeopt jaeopt reopened this Dec 14, 2022
@jaeopt jaeopt closed this Dec 14, 2022
@jaeopt jaeopt reopened this Dec 14, 2022
@jaeopt jaeopt closed this Dec 15, 2022
@jaeopt jaeopt reopened this Dec 15, 2022
@jaeopt jaeopt closed this Dec 15, 2022
@jaeopt jaeopt reopened this Dec 15, 2022
msohailhussain
msohailhussain approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jaeopt jaeopt merged commit 2898a18 into master Dec 16, 2022
@jaeopt jaeopt deleted the jae/ats-2 branch December 16, 2022 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@msohailhussain msohailhussain msohailhussain approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jaeopt jaeopt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jaeopt @coveralls @msohailhussain