-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Support updating tools from dashboard #719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
241e89f to
9583e87
Compare
Was this successfully tested with any client? Because if it can be shown that the implementation works correctly, we could merge it but disable it in the frontend, so it cannot actually be used. (Otherwise, we might get too many conflicts, especially if we refactor the Dashboard.) |
9583e87 to
fb7a0ab
Compare
|
Now tested with VSCode. Limitations: currently only works in stdio mode (see below). They can be overcome, but that requires even more hackery, so let's do that later My previous approach (an So after a lot of crying and deliberation about life choices, I now have solved it by extending
Since fastmcp is async first, we can't call these methods from outside (not thread safe) without the following trickery:
As part of this PR, I also added an mcp configuration that uses serena on serena in VSCode Btw, serena is on the VSC marketplace: Not sure what exactly the install button there will do... |
fb7a0ab to
dd78df3
Compare
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
Using a dedicated tool _update_tool_list which is added to the server at the very end. Unfortunately, there seems to be no better way to do that, as the session object is not exposed in the mcp sdk in other places than the tool's context
Doesn't work in Claude Code or Claude Desktop
Anthropic's products don't follow Anthropic's own specifications...
anthropics/claude-code#4118
We probably shouldn't merge until Anthropic resolves it