Skip to content

Split a tweet into blocks in not only space but also newline#234

Open
amane-katagiri wants to merge 1 commit intoorakaro:masterfrom
amane-katagiri:feature/fix_color_of_message
Open

Split a tweet into blocks in not only space but also newline#234
amane-katagiri wants to merge 1 commit intoorakaro:masterfrom
amane-katagiri:feature/fix_color_of_message

Conversation

@amane-katagiri
Copy link
Copy Markdown
Contributor

I changed draw function to split tweets by not only space but also newline.

A URL/screen_name/hashtag/... block contains an extra text if it end in newline, because draw function splits a tweet into a block by only space.

Example:

Visit this page !! http://example.com/
これが私のウェブサイトです。

If the example is splited by only space, http://example.com/\nこれが私のウェブサイトです。 is colored. My change adds a color to only http://example.com/\n.

@amane-katagiri amane-katagiri force-pushed the feature/fix_color_of_message branch from a8884f4 to cc25f5b Compare May 18, 2017 04:47
@amane-katagiri amane-katagiri changed the title Color the text block splited by space only before newline Split a tweet into blocks in not only space but also newline May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants