Closed
Conversation
0d80a0e to
15bea30
Compare
| export default class extends Component<Args> { | ||
| @use data = useLiveQuery((q) => | ||
| this.args.id | ||
| ? q.findRecord({ type: 'planet', id: this.args.id }) |
Contributor
There was a problem hiding this comment.
does this re-run if the args change?
Contributor
Author
There was a problem hiding this comment.
I think it will not. After some thoughts, I think we should wait for invokeHelper/use apis to settle.
Contributor
Author
|
Closing in favour of #276 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implementation relies on a helper which is meant to be used through emberjs/rfcs#626
I also implemented a
@useapi borrowing fromember-usable.It looks like this:
I know that https://github.com/LevelbossMike/ember-statecharts shipped something similar. I really don't know if it is a bad idea/too early for orbit to ship something like this. But at least it shows the direction where we might want to go.
cc @NullVoxPopuli @LevelbossMike