Skip to content

Make dudect ready for C++#23

Merged
oreparaz merged 3 commits intooreparaz:masterfrom
FAlbertDev:fix/cpp_ready
Aug 24, 2023
Merged

Make dudect ready for C++#23
oreparaz merged 3 commits intooreparaz:masterfrom
FAlbertDev:fix/cpp_ready

Conversation

@FAlbertDev
Copy link
Contributor

  • Rename variables named class into clazz
  • Add explicit casts for calloc
  • Remove spaces at line end (not C++ relevant)

- Rename variables named class into clazz
- Add explicit casts for calloc
@oreparaz
Copy link
Owner

Thanks. I'm positive about this. Two questions:

@FAlbertDev
Copy link
Contributor Author

Shouldn't we include the extern "C" {...} logic around this (possibly guarded by __cplusplus)?

Sure! I did't know about this. (added in d9241fe)

Did you test this? how?

I used the following CMake example project, using the dudect.h header:
dudect_cpp_example.zip

Build and execute:
cmake . && make && ./dudect_example

@oreparaz
Copy link
Owner

Thanks! Merging...

@oreparaz oreparaz merged commit 05b48d8 into oreparaz:master Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants