Add two settings to configure relative path for file links.#773
Merged
nevenz merged 1 commit intoorgzly:masterfrom Nov 20, 2020
Merged
Add two settings to configure relative path for file links.#773nevenz merged 1 commit intoorgzly:masterfrom
nevenz merged 1 commit intoorgzly:masterfrom
Conversation
Member
|
I've moved (and renamed in the process) preferences under "Note", as they are not used only for images. I've also removed default from We might want to add a preference for Thanks! |
|
Hi, this a great feature, just wanted to point out that the documentation lists this option as already available while it's actually yet to be released. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #496
Current behavior was
file:/xxxrelative to root.file:xxxrelative to Environment.getExternalStorageDirectory().getPath().The new behavior in this commit is:
file:/xxxrelative to pref AppPreferences#fileAbsoluteRoot(), default to "/"file:xxxrelative to pref AppPreferences#fileRelativeRoot(), default to Environment.getExternalStorageDirectory().getPath()Added two basic settings in the Image category for these two prefs. The setting is text only, could potentially be directoyr picker.
The path following behavior is changed in
ImageLoaderandWidget.followLinkToFile, now both usesLinkFindTarget.