Indirect selection with Shift Key is not working correctly

[romankarnes]

When using the shift key the count of selected rows is not correct.

Using this link: http://oria.github.io/gridx/demos/indirectSelect.html

In the grid under "IndirectSelect with extended selection"

Steps to recreate:
1: Click checkbox for row 2 (Identity column = 1)
2: Hold shift key and click checkbox for row 3 (Identity = 2) NOTICE selected count number is 2
3: With shift key still pressed click row 1 (Identity = 0). NOTICE selected count number is is now 3 but there is only 2 rows which contain a checkbox.

This is a big issue for our app, we are currently looking at the gridx code to find a fix. But if someone has one could you please post it.

Thank you
Roman

[blueleader07]

In addition to the row counts being off, the rows themselves get rechecked. I've posted a youtube video to demonstrate the issue here.
http://youtu.be/X_IdtDZt_xA

I've also created a pull request with our fix.

[blueleader07]

Updated the pull request. We found a performance issue with our original submission during our UAT testing. The updated pull request does not have a performance issue. Please let me know if you'd like me to elaborate. Long story short we were deselecting rows within a for loop and that created the performance issue. Instead, we are deselecting in bulk AFTER the for loop. Take a look at the pull request and you'll see what I mean.