Unbreak height computation on non-IE #365
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a regression introduced by 0863aff: On browsers other than IE, `ie` is set to `false` and since `false > 8` is not true, the row height was truncated. This would typically show up when using Grids inside a TabContainer, since the onShow event triggers a resize. The fix reorders the branch to match the corresponding order in `getHeight()` earlier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a regression introduced by 0863aff: On browsers other than IE,
ieis set tofalseand sincefalse > 8is not true, the row height was truncated. This would typically show up when using Grids inside a TabContainer, since the onShow event triggers a resize. The fix reorders the branch to match the corresponding order ingetHeight()earlier.