Skip to content

Fix for jumping glitch while scrolling with the VirtualVScroller #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jrwerkman wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for jumping glitch while scrolling with the VirtualVScroller #442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions modules/VirtualVScroller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,14 +280,8 @@ define([
if(typeof start == 'number' && typeof end == 'number'){
//Only need to render when the range is valid
body.renderRows(start, end - start, pos);
if(a && start < end){
//Scroll the body to hide the newly added top rows.
var n = query('[visualindex="' + end + '"]', bn)[0];
if(n){
deltaT += n.offsetTop;
}
}
}
}

//Ensure the position when user scrolls to end points
if(nearTop){
bn.scrollTop = 0;
Expand All @@ -298,7 +292,11 @@ define([
bn.scrollTop += deltaT;
}
}
t._doVirtual();

// Same (reversed criteria), when new rows
// are rendered, skip _doVirtual.
if(typeof start != 'number' || typeof end != 'number')
t._doVirtual();
},

_doScroll: function(e, forced, noLazy){
Expand Down