removing _containsConnection in ODatabase which causes a connection to never get closed#144
Open
jocelynk wants to merge 1 commit intoorientechnologies:masterfrom
Open
removing _containsConnection in ODatabase which causes a connection to never get closed#144jocelynk wants to merge 1 commit intoorientechnologies:masterfrom
jocelynk wants to merge 1 commit intoorientechnologies:masterfrom
Conversation
This was referenced Sep 29, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
Close()method of theODatabaseclass it does a check for_containsConnection, but that instance variable is never set to true so the connection is never closed. Adding a fix to remove this check, as theClose()method in theConnectionclass does a check for active connections before it closes the connection.