Skip to content

Minimal implementation of search#11

Open
skissane wants to merge 1 commit intoorisano:masterfrom
skissane:search
Open

Minimal implementation of search#11
skissane wants to merge 1 commit intoorisano:masterfrom
skissane:search

Conversation

@skissane
Copy link
Copy Markdown

This just does the bare minimum to add a search function (#10)

A lot of things are missing:

  • only exact match, no support for inexact matches (substring, glob, regex, etc)
  • should -d option be ignored when searching?
  • silently ignored with interactive mode; maybe it should display an error for unsupported combination of options?
  • exit status could communicate whether match is found or not (like grep)

But it is a start.

@skissane skissane changed the title Minimal implementation of search (#10) Minimal implementation of search Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants