Skip to content

fix: adding the link to documentation section#1694

Closed
maca-sys wants to merge 1 commit into
ory:masterfrom
maca-sys:patch-1
Closed

fix: adding the link to documentation section#1694
maca-sys wants to merge 1 commit into
ory:masterfrom
maca-sys:patch-1

Conversation

@maca-sys
Copy link
Copy Markdown

a link for (#documentation) was missing, so I added the link to the last sentence in "How can I contribute?" section.
I didn't find any develop branch, so I raised the pr for master branch, if I have to change it, please let me know.

link for (#documentation) was added to the sentence in "How can I contribute?" section
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Aug 29, 2021

CLA assistant check
All committers have signed the CLA.

@maca-sys maca-sys changed the title adding the link to documentation section fix: adding the link to documentation section Aug 29, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 29, 2021

Codecov Report

Merging #1694 (918fe81) into master (e7a237a) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1694      +/-   ##
==========================================
- Coverage   74.25%   74.20%   -0.06%     
==========================================
  Files         259      259              
  Lines       12618    12618              
==========================================
- Hits         9370     9363       -7     
- Misses       2627     2634       +7     
  Partials      621      621              
Impacted Files Coverage Δ
cmd/courier/watch.go 60.34% <0.00%> (-12.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7a237a...918fe81. Read the comment docs.

@zepatrik zepatrik requested review from vinckr and removed request for aeneasr and zepatrik August 30, 2021 12:02
Comment thread CONTRIBUTING.md
for proper spelling and grammar. If you think a document can be improved in
any way, feel free to hit the `edit` button at the top of the page. More info
on contributing to documentation here.
on contributing to documentation [here](#documentation).
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinckr can you move this to meta?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, thanks for catching this @masoudtahmasebi93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants