Skip to content

fix: grammatical error of documentation #121

Merged
aeneasr merged 2 commits into
ory:masterfrom
idivyanshbansal:patch-1
Oct 25, 2021
Merged

fix: grammatical error of documentation #121
aeneasr merged 2 commits into
ory:masterfrom
idivyanshbansal:patch-1

Conversation

@idivyanshbansal
Copy link
Copy Markdown
Contributor

Extension to ory/hydra#2798 PR of Hydra as this is part of its readme file

Copy link
Copy Markdown
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making contributions to the Ory ecosystem. Unfortunately, many of your contributions contain changes which do not improve the state but instead change something that does not make sense. For example:

.. is an API-first Identity and User management system that is built according ...

is very clear. It is an identity and user management system!

The change:

.. is an API-first Identity and User A management system that is built according ...

just does not make any sense from a language stand point. Mistakes can happen to anyone. Unfortunately many of your changes are like this.

It takes a lot of time and effort to review pull requests, and maintainers expect a certain degree of quality. Otherwise we spend a lot of time reviewing things that are wrong changes, and could have used the time instead to review PRs with functional changes and substantial improvements that help and advance the community.

Please refrain from making further PRs that make language changes which are incorrect, and focus on things that really improve things. If we continue to receive low quality PRs from your account we will have to auto-reject PRs from your account.

Comment thread templates/repository/common/PROJECTS.md Outdated
[Ory Kratos](https://github.com/ory/kratos) is an API-first Identity and User
Management system that is built according to
[cloud architecture best practices](https://www.ory.sh/docs/next/ecosystem/software-architecture-philosophy).
A management system that is built according to
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this

Comment thread templates/repository/common/PROJECTS.md Outdated
Management system that is built according to
[cloud architecture best practices](https://www.ory.sh/docs/next/ecosystem/software-architecture-philosophy).
A management system that is built according to
[Cloud architecture best practices](https://www.ory.sh/docs/next/ecosystem/software-architecture-philosophy).
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this

Comment thread templates/repository/common/PROJECTS.md Outdated
[Ory Hydra](https://github.com/ory/hydra) is an OpenID Certified™ OAuth2 and
OpenID Connect Provider which easily connects to any existing identity system by
writing a tiny "bridge" application. Gives absolute control over user interface
writing a tiny "bridge" application. Gives absolute control over the user interface
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this

Comment thread templates/repository/common/PROJECTS.md Outdated
such as Kubernetes, CloudFoundry, OpenShift, and similar projects. Binaries are
small (5-15MB) and available for all popular processor types (ARM, AMD64, i386)
and operating systems (FreeBSD, Linux, macOS, Windows) without system
and operating systems (FreeBSD, Linux, macOS, Windows) without systems.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this

@idivyanshbansal
Copy link
Copy Markdown
Contributor Author

@aeneasr sir, I have reverted it

Copy link
Copy Markdown
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@aeneasr aeneasr merged commit 6989295 into ory:master Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants