fix: Limit OpenCollective contributor image size#124
Merged
Conversation
HeroCC
changed the title
vinckr
reviewed
Oct 20, 2021
Member
vinckr
left a comment
vinckr
left a comment
There was a problem hiding this comment.
Thanks for looking into this!
I could not confirm the 5MB limit, but the file has the correct size, so I would say this is looking good 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenCollective individual contributor badge was being dropped by Github Camo for being too large. This PR limits the number of profile pics returned, reducing the size of the image. GitHub Camo seems to limit at 5Mb, and the limited image comes out to a bit over 4.5MB, which should be just enough wiggle room for if someone moves up the rankings or changes profile pictures.
See ory/kratos#1857