Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ Usage: $this [-b] bindir [-d] <project> [<tag>]
- kratos - downloads Ory Kratos
- hydra - downloads Ory Hydra
- oathkeeper - downloads Ory Oathkeeper
- talos - downloads Ory Talos
- ory - downloads the Ory CLI

-b sets bindir or installation directory, Defaults to ./bin
Expand Down Expand Up @@ -47,7 +48,7 @@ parse_args() {
done
shift $((OPTIND - 1))

[ -z "$1" ] && (echo "Please specify the project you want to download. Possible values are: keto, kratos, hydra, oathkeeper, ory." && exit 1)
[ -z "$1" ] && (echo "Please specify the project you want to download. Possible values are: keto, kratos, hydra, oathkeeper, talos, ory." && exit 1)
TAG=$2

case "$1" in
Expand Down Expand Up @@ -83,8 +84,15 @@ parse_args() {
FLAVOR=""
;;

talos)
REPO="talos"
BINARY=talos
PROJECT_NAME=talos
FLAVOR=""
;;

*)
echo "The project you specified is unknown. Please choose one of \"ory\", \"keto\", \"kratos\", \"oathkeeper\". Received \"$1\"."
echo "The project you specified is unknown. Please choose one of \"ory\", \"keto\", \"kratos\", \"oathkeeper\", \"talos\". Received \"$1\"."
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Add "hydra" to the error message.

The error message lists valid projects but is missing "hydra", which is a supported option (line 74). Users receiving this error would not know that "hydra" is available.

📝 Proposed fix
-		echo "The project you specified is unknown. Please choose one of \"ory\", \"keto\", \"kratos\", \"oathkeeper\", \"talos\". Received \"$1\"."
+		echo "The project you specified is unknown. Please choose one of \"ory\", \"keto\", \"kratos\", \"hydra\", \"oathkeeper\", \"talos\". Received \"$1\"."
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
echo "The project you specified is unknown. Please choose one of \"ory\", \"keto\", \"kratos\", \"oathkeeper\", \"talos\". Received \"$1\"."
echo "The project you specified is unknown. Please choose one of \"ory\", \"keto\", \"kratos\", \"hydra\", \"oathkeeper\", \"talos\". Received \"$1\"."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@install.sh` at line 95, Update the error message in the install.sh script
where the project validation echo is printed (the echo that currently lists
"ory", "keto", "kratos", "oathkeeper", "talos") to include "hydra" so the
supported options message matches the valid-project check (the validation logic
around $1 / project selection and the echo statement should be updated
together); ensure the echo string now lists "ory", "keto", "kratos",
"oathkeeper", "talos", "hydra" exactly as other messages reference.

exit 1
;;
esac
Expand Down
2 changes: 2 additions & 0 deletions scripts/sync.sh
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ function replicate_all {
declare -A name_map=(
["hydra"]="Hydra"
["keto"]="Keto"
["talos"]="Talos"
["oathkeeper"]="Oathkeeper"
["kratos"]="Kratos"
["hydra-login-consent-node"]="Hydra Login, Logout And Consent Node Example"
Expand Down Expand Up @@ -106,6 +107,7 @@ function replicate_all {
"keto"
"oathkeeper"
"kratos"
"talos"
"elements"
"polis"
"x"
Expand Down
Loading