Allow time overlaps, includes tests #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix checking for time order. * permit overlap of cues (not comparing end to start, but start to start)
Allow overlapping cues, which is done by comparing starting points instead of end-versus start points. Perhaps a warning should be emitted in case of overlapping cues?
Owner
|
Thanks @autotel |
Owner
|
Released in v1.8.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I paid a fast review of the standard, and I didn't find anything with regard to cues ending after the next cue started, but I found some examples which seemed to suggest that it is valid. (example 8 at https://www.w3.org/TR/webvtt1/)