Skip to content

Conversation

@jagdish7908
Copy link
Contributor

Fixed calculation issues in parser and compiler

Parser

Output is incorrect for some timestamps if integers are added to floating point.
image
Sample timestamps for which current function was giving incorrect result
01:24:40.060

Compiler

floatNumber%1 without precision limit changes output
image
Sample timestamps for which current function gives incorrect result

00:19:59.529
00:19:59.539
00:19:59.549
00:19:59.558
01:24:35.275

@osk
Copy link
Owner

osk commented May 20, 2020

@jagdish7908 thanks for this, can you add a failing test for the example cases so we don't introduce a regression later on?

@jagdish7908
Copy link
Contributor Author

@osk added test cases

@osk osk merged commit bf144fa into osk:master May 21, 2020
@osk
Copy link
Owner

osk commented May 21, 2020

@jagdish7908 thanks! this is released in v1.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants