ROS 2 images are also hosted in the official ros library#285
Closed
mikaelarguedas wants to merge 1 commit intomasterfrom
Closed
ROS 2 images are also hosted in the official ros library#285mikaelarguedas wants to merge 1 commit intomasterfrom
mikaelarguedas wants to merge 1 commit intomasterfrom
Conversation
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
ItsHarper
reviewed
Jun 21, 2019
ItsHarper
left a comment
ItsHarper
left a comment
There was a problem hiding this comment.
It would also be helpful to have some indication of why you would choose osrf vs docker official images in general.
Contributor
Author
|
Superseded by #305 @noahAndrews FYI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minimal change to point ROS 2 users to the official library.
We could consider providing more context about what "ROS 2 development images" mean
Attempt to fix #283