Reconcile templates and generated files + add nightly templates#79
Merged
mikaelarguedas merged 4 commits intomasterfrom Dec 23, 2019
Merged
Reconcile templates and generated files + add nightly templates#79mikaelarguedas merged 4 commits intomasterfrom
mikaelarguedas merged 4 commits intomasterfrom
Conversation
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
This was referenced Dec 22, 2019
ruffsl
approved these changes
Dec 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The source and nightly images started diverging significantly from the templates, and the nightly-rmw* images dont have a template of their own.
New snppets:
Templates now take
env_beforeandenv_afterto pass env vars that the template should definediff after this PR with images that will land on master
I kept thos manual changes as they are expected to be temporary and dont belong in the tmeplate. Can be added to the templates if preferred